feat(Tappable): expose onPointerDown and onPointerCancel props #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #102 |
mainsmirnov
reviewed
Jul 2, 2025
| @@ -36,8 +48,8 @@ export const Tappable = forwardRef(({ | |||
| interactiveAnimation === 'opacity' && styles['wrapper--opacity'], | |||
| className, | |||
| )} | |||
| onPointerCancel={onPointerCancel} | |||
| onPointerDown={onPointerDown} | |||
| onPointerCancel={handlePointerCancel} | |||
There was a problem hiding this comment.
Thank you for your issue and contribution!
It would be preferred to use function callMultiple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Button component in TelegramUI uses a Tappable under the hood, which relies on onPointerDown and onPointerCancel for the ripple effect via the useRipple hook.
But since the Button doesn't explicitly support onPointerDown and onPointerUp props, there's no clean way to hook into these events from the outside. And even if you try to pass them manually through restProps, they end up replacing the internal handlers — which breaks the ripple effect.